On 04/08/2023 12:27, like@xxxxxxxxxx wrote:
> From: Alec Li <like@xxxxxxxxxx>
>
...
Subject: no improvements
> +
> +properties:
> + compatible:
> + const: awinic,aw37503
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^out[pn]$":
> + type: object
> + $ref: regulator.yaml#
This does not make much sense. You had here unvaluatedProperties. Why
dropping it? I asked to drop additionalProperties. Open the email and
look where the comments are given. In which context.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - outp
> + - outn
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + regulator@3e {
> + compatible = "awinic,aw37503";
> + reg = <0x3e>;
> +
> + outp {
> + regulator-name = "outp";
> + regulator-boot-on;
> + regulator-always-on;
> + enable-gpios = <&gpio 17 0>;
Please use proper defines.... you included the header for this.
Best regards,
Krzysztof
