This series adds initial support for the eMMC on the BeagleV Ahead
board. This allows the kernel to boot with the root fs on eMMC.
I tested [1] on top of v6.5-rc3 with this config [2] along with the
prerequisite series [3] that adds the BeagleV Ahead dts file.
I am submitting this as an RFC for other people that want to test
booting from the eMMC with mainline. There are several issues that need
to be resolved before this code can progress beyond an RFC:
- Only the MMC controller connected to the eMMC is enabled. I did
not yet attempt to configure or use the microSD card slot.
- The thead,th1520-dwcmshc compatible sets quirks which disable DMA
and forces the use of inefficient PIO mode. I need to determine the
correct configuration for the SDMA and ADMA modes.
- th1520-specific code is needed in dwcmshc_set_uhs_signaling() for
MMC_TIMING_MMC_HS400. I have not figured out add proper way to make
that code conditional so that it only runs on th1520. One method
could be to add a th1520 flag to dwcmshc_priv but that seems like a
hack. Alternatively, set_uhs_signaling in sdhci_dwcmshc_th1520_ops
could point to a th1520-specific function, but that new function
would have to duplicate all the code in the current
dwcmshc_set_uhs_signaling().
NOTE: I combined schema, dts and driver patches into this one series to
simplify review and testing of this RFC.
References:
[1] https://gist.github.com/pdp7/09995be1e30df0a04b9b9cd31420f9d5
[2] https://gist.github.com/pdp7/e4585311eb2cd27df7b50c87babc15fd
[3] https://lore.kernel.org/linux-riscv/20230722-upstream-beaglev-ahead-dts-v2-0-a470ab8fe806@xxxxxxxxxxxx/
Changes in v2:
- Expand dwcmshc_priv based on driver in the T-Head 5.10 kernel:
delay_line, non_removable, pull_up_en, io_fixed_1v8
- New boolean property "thead,pull-up" indicates phy pull-up config
- New boolean property "thead,io-fixed-1v8" indicates that io voltage
should be set to 1.8V during reset
- Add th1520_phy_1_8v_init() as voltage_switch op
- Add th1520_execute_tuning() as the platform_execute_tuning op
- Added th1520_sdhci_reset() as the .reset op. This function will set
io voltage to 1.8V after calling the standard sdhci_reset() function.
- Modified dwcmshc_set_uhs_signaling() to enable SDHCI_CTRL_VDD_180 when
io_fixed_1v8 is true
- Add many defines for register offsets and settings based on the mmc
support in the T-Head downstream v5.10 kernel
v1 series:
https://lore.kernel.org/r/20230724-th1520-emmc-v1-0-cca1b2533da2@xxxxxxxxxxxx
Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxx>
---
Drew Fustini (4):
dt-bindings: mmc: sdhci-of-dwcmhsc: Add T-Head TH1520 support
riscv: dts: thead: Add TH1520 mmc controller and sdhci clock
riscv: dts: thead: Enable BeagleV Ahead eMMC controller
mmc: sdhci-of-dwcmshc: Add support for T-Head TH1520
.../bindings/mmc/snps,dwcmshc-sdhci.yaml | 9 +
arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 17 ++
arch/riscv/boot/dts/thead/th1520.dtsi | 17 ++
drivers/mmc/host/sdhci-of-dwcmshc.c | 336 +++++++++++++++++++++
4 files changed, 379 insertions(+)
---
base-commit: cb8c874afdc063290797ae1776a5d410fecb06cb
change-id: 20230724-th1520-emmc-73cde98805d6
Best regards,
--
Drew Fustini <dfustini@xxxxxxxxxxxx>
