On Mon, 31 Jul 2023 17:59:14 +0200 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jul 25, 2023 at 10:23:40AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Add call to uart_get_rs485_mode() to probe for RS485 flags and > > properties from device tree. > > Again, you are saying what you are doing, but not why. I have no hint > as to if this is a bugfix, or a new features, or something else? > > thanks, > > greg k-h Hi Greg, I could change the commit message to: --------- serial: sc16is7xx: add missing support for rs485 devicetree properties Retrieve rs485 devicetree properties on registration of sc16is7xx ports in case they are attached to an rs485 transceiver. --------- I don't think that it should be considered as a bug fix, but maybe as a missing feature. And does it mean that it should also go to older (stable) kernels then? If yes, then do I need to add the "Fixes" tag? Thank you, Hugo.