On 17:10-20230802, Jai Luthra wrote: > Hi Devarsh, > > On Aug 02, 2023 at 16:15:12 +0530, Devarsh Thakkar wrote: > > Hi Jai, > > > > Thanks for the patch. > > > > On 31/07/23 18:14, Jai Luthra wrote: > > > Add nodes for audio codec and sound card, enable the audio serializer > > > (McASP1) under use and update pinmux. > > > > > > Link: https://www.ti.com/lit/zip/sprr459 > > > Signed-off-by: Jai Luthra <j-luthra@xxxxxx> > > > Reviewed-by: Jayesh Choudhary <j-choudhary@xxxxxx> > > > --- > > > arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 77 +++++++++++++++++++++++++++++++++ > > > 1 file changed, 77 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts > > > index 752c2f640f63..5f68d2eefe0f 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts > > > +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts > > > @@ -125,6 +125,41 @@ led-0 { > > > default-state = "off"; > > > }; > > > }; > > > + > > > + tlv320_mclk: clk-0 { > > > + #clock-cells = <0>; > > > + compatible = "fixed-clock"; > > > + clock-frequency = <12288000>; > > > + }; > > > + > > > + codec_audio: sound { > > > + compatible = "simple-audio-card"; > > > + simple-audio-card,name = "AM62Ax-SKEVM"; > > > > In my opinion better to give the codec name instead of board name here. > > I agree, maybe calling it "sk-am62a-tlv320aic3106" would be the most > clear option. > > Running a quick ripgrep on next tree: > > $ rg "simple-audio-card,name" arch/*/boot/dts/ > > I see a healthy mix of using both board and/or codec name here - with TI > almost always using the board name. Maybe we can change the convention, > but it would be a good idea to at least update SK-AM62 as well to use > the new convention. > > Is it okay with you if it is handled as a separate series? Will this cleanup of existing board break any userspace? If so, NO and follow existing "board" convention - I'd like to maintain consistency, even if that is not exactly clean! If not, cleanup in a later series is fine, but please make sure to follow through this week - with this patch following the convention of choice. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
