On Tue, Aug 01, 2023 at 08:51:30PM +0800, Huqiang Qin wrote:
> Hi Dmitry,
>
> On 2023/7/28 15:15, Dmitry Rokosov wrote:
> > [ EXTERNAL EMAIL ]
> >
> > Hello Huqiang,
> >
> > Thank you for the patch series!
> >
> > Please include a cover letter in future patch submissions if possible.
> > It will help to better understand the theme of the patch series and
> > group all patch sets together in one email thread.
>
> Thank you for your suggestion. In fact, this patch series contains
> a cover letter. It may be due to network reasons that it was not
> sent to your mailbox correctly :)
>
Ah, sorry, you are right... Now I see your cover letter on the
lore.kernel.org... My mail server makes a magic...
> ...
> >> static int meson_gxbb_wdt_start(struct watchdog_device *wdt_dev)
> >> {
> >> struct meson_gxbb_wdt *data = watchdog_get_drvdata(wdt_dev);
> >> @@ -140,8 +143,12 @@ static const struct dev_pm_ops meson_gxbb_wdt_pm_ops = {
> >> SET_SYSTEM_SLEEP_PM_OPS(meson_gxbb_wdt_suspend, meson_gxbb_wdt_resume)
> >> };
> >>
> >> +static const struct wdt_params gxbb_params = {
> >> + .rst_shift = 21,
> >
> > Maybe it's better to declare rst with the BIT() macro already applied,
> > and use it in wdt_probe() as is. And name 'rst' without 'shift' is
> > looking more brief.
>
> Okay, I will change it in the next version.
>
>
> Thanks
>
> Best Regards,
> Huqiang Qin
--
Thank you,
Dmitry
