Hello Hans, Please find my comments inlined. On 12/13/14, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi VishnuPatekar, > > The patch mangling for this set seems to have gone a bit wrong I'm afraid No, this time I've corrected it. Infact, last version of patch did not used the status bit error macros. > a lot of the patches have my fixup commit messages (which should have > disappeared when squashing in the patches), please replace those by proper > commit messages describing what the patch actually does. Yes, [PATCHv3 3/5] uses fixup. I'll correct it. > > Also the adding of the commented nodes for the lime2 seems to be gone > entirely > from the set, instead now only a comment about the conflict with the hdmi > pins is added, but it is above the i2c node instead of above a ps2 node. > Maxime's suggested that we should not add commented nodes specially when its trivial to apply. And just note saying ps20 pins conflict with HDMI. Should I remove the this comment as well? Or Put this note in start of DTS file? > Regards, > > Hans > > > On 12-12-14 19:25, VishnuPatekar wrote: >> v2 --> v3 >> 1. changed config to SERIO_SUN4I_PS2 from SERIO_SUNXI_PS2 >> 2. changed driver name to sun4i-ps2 from sunxi-ps2. >> 3. changed the function names to sun4i_ps2_*. >> 4. added locking in sun4i_ps2_open. >> 5. kept compatible "sun4i-a10-ps2" for A10 and A20, as A10 is earlier >> SOC. >> 6. corrected the style errors. >> 7. separated the dts patches. >> 8. removed commented ps2 notes from lime2 dts. >> 9. added note that ps2 pins confilt with hdmi. >> 10. corrected the interrupt property for A10. >> 11. moved dt-bindings to Documentation/devicetree/bindings/serio >> >> v1 --> v2: >> 1. added default n depends on ARCH_SUNXI || COMPILE_TEST in Kconfig. >> 2. handled errors and free resources on errors. >> 3. used BIT(x), DIV_ROUND_UP macros. >> 4. corrected style errors. >> 5. added support for A10 also, A10 and A2 have same properties of PS2 >> controller. >> 6. by default commented ps20 and ps21 nodes,as ps20 pins conflict with >> HDMI. >> 7. added compatible as allwinner,sun4i-a10-ps2. >> 8. corrected the possible race condition. >> >> >> VishnuPatekar (5): >> sunxi:dts-bindings:input:ps2 bindings for A10/A20 ps2. >> ARM:sunxi:drivers:input Add support for A10/A20 PS2 >> ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20 >> ARM: sunxi: dts: Add A10/A20 PS2 pin muxing options >> ARM: sunxi: dts: Add note ps2 pins conflict with hdmi >> >> .../bindings/serio/allwinner,sun4i-ps2.txt | 23 ++ >> arch/arm/boot/dts/sun4i-a10.dtsi | 31 ++ >> arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 6 +- >> arch/arm/boot/dts/sun7i-a20.dtsi | 32 ++ >> drivers/input/serio/Kconfig | 11 + >> drivers/input/serio/Makefile | 1 + >> drivers/input/serio/sun4i-ps2.c | 362 >> ++++++++++++++++++++ >> 7 files changed, 465 insertions(+), 1 deletion(-) >> create mode 100644 >> Documentation/devicetree/bindings/serio/allwinner,sun4i-ps2.txt >> create mode 100644 drivers/input/serio/sun4i-ps2.c >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
