On Tue, Jul 25, 2023 at 10:23:35AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later
> in probe") moved GPIO setup code later in probe function. Doing so
> also required to move ports cleanup code (out_ports label) after the
> GPIO cleanup code.
>
> After these moves, the out_thread label becomes misplaced and makes
> part of the cleanup code illogical.
>
> This patch remove the now obsolete out_thread label and make GPIO
> setup code jump to out_ports label if it fails.
>
> Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe")
> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> Reviewed-by: Lech Perczak <lech.perczak@xxxxxxxxxxxxxxx>
> Tested-by: Lech Perczak <lech.perczak@xxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Why is this not ok for stable kernels yet it has a Fixes: tag?
Please fix.
thanks,
greg k-h
