On 31/07/2023 09:21, Tengfei Fan wrote: > > > 在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道: >> On 31/07/2023 08:13, Tengfei Fan wrote: >>> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent >>> sequence of numbers. >>> >>> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 >> >> Please run scripts/checkpatch.pl and fix reported warnings. Some >> warnings can be ignored, but the code here looks like it needs a fix. >> Feel free to get in touch if the warning is not clear. >> > sure, will do this check if this patch still need. I understand that resending this might not be needed, but just to clarify: you must run checkpatch on all your patches before sending them. This is the most basic step required before sending anything. Best regards, Krzysztof