On Mon, Jul 31, 2023 at 11:04 AM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote: > > On Sun, Jul 30, 2023 at 4:26 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > > > On 29/07/2023 15:43, Keguang Zhang wrote: > > > Add UART device nodes for Loongson-1 boards, > > > and drop the legacy platform devices and data accordingly. > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > > --- > > > arch/mips/boot/dts/loongson/loongson1.dtsi | 54 +++++++++++++++++++ > > > > Same problem - DTS is always separate. It seems you made this mistake > > everywhere, so entire patchset needs to be fixed. Keep all DTS - your > > base board and extending it - at the end of the patchset and squash it. > > There is little point to add new DTS in steps (e.g. first add incomplete > > broken DTS and then immediately fix it... no, instead just add correct > > and complete DTS). > > > Sorry. I thought it would be easier to review for split patches. > Thanks for the explanation. > Will send v2 with one complete DTS. Hello Thomas, May I ask your opinion about the way to delete the obsolete platform devices? Should I delete them in one patch? Or in separated patches? Thanks! > > > > Best regards, > > Krzysztof > > > > > -- > Best regards, > > Keguang Zhang -- Best regards, Keguang Zhang
