Hi Rob, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.5-rc3 next-20230728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Rob-Herring/of-dynamic-Refactor-action-prints-to-not-use-pOF-inside-devtree_lock/20230729-072155 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230728231950.1619073-1-robh%40kernel.org patch subject: [PATCH v3] of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock config: i386-randconfig-i014-20230728 (https://download.01.org/0day-ci/archive/20230729/202307291901.IEr9LCpd-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291901.IEr9LCpd-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202307291901.IEr9LCpd-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/of/dynamic.c:74:6: warning: no previous prototype for function 'of_changeset_action_print' [-Wmissing-prototypes] void of_changeset_action_print(unsigned long action, struct device_node *np, const char *prop_name) ^ drivers/of/dynamic.c:74:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void of_changeset_action_print(unsigned long action, struct device_node *np, const char *prop_name) ^ static >> drivers/of/dynamic.c:87:6: error: expected expression if (pr_debug("notify ")) ^ include/linux/printk.h:579:2: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:267:2: note: expanded from macro 'dynamic_pr_debug' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^ include/linux/dynamic_debug.h:248:2: note: expanded from macro '_dynamic_func_call' _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:246:2: note: expanded from macro '_dynamic_func_call_cls' __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:219:58: note: expanded from macro '__dynamic_func_call_cls' #define __dynamic_func_call_cls(id, cls, fmt, func, ...) do { \ ^ drivers/of/dynamic.c:571:6: error: expected expression if (pr_debug("changeset: applying: cset<%p> ", ce)) ^ include/linux/printk.h:579:2: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:267:2: note: expanded from macro 'dynamic_pr_debug' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^ include/linux/dynamic_debug.h:248:2: note: expanded from macro '_dynamic_func_call' _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:246:2: note: expanded from macro '_dynamic_func_call_cls' __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__) ^ include/linux/dynamic_debug.h:219:58: note: expanded from macro '__dynamic_func_call_cls' #define __dynamic_func_call_cls(id, cls, fmt, func, ...) do { \ ^ 1 warning and 2 errors generated. vim +87 drivers/of/dynamic.c 81 82 int of_reconfig_notify(unsigned long action, struct of_reconfig_data *p) 83 { 84 int rc; 85 struct of_reconfig_data *pr = p; 86 > 87 if (pr_debug("notify ")) 88 of_changeset_action_print(action, pr->dn, pr->prop ? pr->prop->name : NULL); 89 90 rc = blocking_notifier_call_chain(&of_reconfig_chain, action, p); 91 return notifier_to_errno(rc); 92 } 93 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
