On 28/07/2023 12:23, Varshini Rajendran wrote: > Add documentation for sam9x7 ethernet interface. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index bf8894a0257e..c9840a284322 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -59,6 +59,12 @@ properties: > - cdns,gem # Generic > - cdns,macb # Generic > > + - items: > + - enum: > + - microchip,sam9x7-gem # Microchip SAM9X7 gigabit ethernet interface > + - enum: > + - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface That's entirely different patch than before. Not correct also - drop the second enum, because it cannot be enum. Please provide changelogs explaining what happened in the patch. Sending such huge patchset with changelog only in cover letter with very vague description of changes is not helping. Best regards, Krzysztof