Re: [PATCH 00/13] of: overlay/unittest: Miscellaneous fixes and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/20/23 13:37, Rob Herring wrote:
> On Wed, Jul 19, 2023 at 05:00:00PM +0200, Geert Uytterhoeven wrote:
>> 	Hi all,
>>
>> This patch series contains miscellaneous fixes and improvements for
>> dynamic DT overlays and the related unit tests.
>>
>> The first two patches are fixes for a lock-up and a crash.
>> The remaining patches are smaller fixes, enhancements and cleanups for
>> the overlay tests, including one new test.
>>
>> I ran into the crash when accidentally loading the wrong overlay (using
>> the out-of-tree DT overlay configfs[1]), and removing it afterwards.
>> As this case was not yet covered by the unittests, I added a test.
>> I enhanced the tests to clean up partial state after a failed
>> overlay apply attempt, which triggered the lock-up.
>>
>> Thanks for your comments!
> 
> Other than my comments all looks good to me. Of course, I treat code 
> deletions, documentation additions, and test additions the same: 
> automatic acceptance. ;)
> 
> I'll give it a bit more time in case Frank has comments.

Thanks Rob, but no need to wait for me as I'm easing out of devicetree.

-Frank

> 
> Rob




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux