On 26/07/2023 22:35, Nicolas Dufresne wrote: > Le mercredi 26 juillet 2023 à 18:33 +0200, Krzysztof Kozlowski a écrit : >> On 26/07/2023 18:26, Devarsh Thakkar wrote: >>> Add dt-bindings for Imagination E5010 JPEG Encoder driver which is >>> implemented as stateful V4L2 M2M driver. >>> >>> Co-developed-by: David Huang <d-huang@xxxxxx> >>> Signed-off-by: David Huang <d-huang@xxxxxx> >> >> A nit, subject: drop second/last, redundant "bindings for". The >> "dt-bindings" prefix is already stating that these are bindings. >> >> Drop also "driver". Bindings are for hardware, not drivers. >> >> Prefix starts with media and then dt-bindings. > > That being said, I haven't seen any submission for the driver using these, is it > common practice to upstream bindings for unsupported hardware ? I assumed I wasn't CC'ed on the user, but it seems there is no user. None, neither drivers, not DTS. Commit msg also doesn't explain it. No point op submit bindings where there are no users. Best regards, Krzysztof
