Am Montag, 24. Juli 2023, 21:22:23 CEST schrieb Sebastian Reichel: > Hi Heiko, > > On Mon, Jul 24, 2023 at 09:12:35PM +0200, Heiko Stuebner wrote: > > On Mon, 17 Jul 2023 19:35:10 +0200, Sebastian Reichel wrote: > > > This adds PCIe v3 support for RK3588. The series depends on the PCIe > > > v2 series [0], since the the same binding is used. It has been tested > > > on Rockchip EVB1 and Radxa Rock 5B. > > > > > > Note, that the PCIe3 PHY driver is currently missing bifurcation > > > support for RK3588. Thus after this series only PCIe3x4 is usable > > > (in aggregated x4 mode) without adding support for the PHY's > > > "rockchip,pcie30-phymode" DT property, which allows configuring > > > how the lanes are distributed. Aggregated 3x4 mode seems to be the > > > most common configuration. Both EVB1 and Rock 5B use it, so I > > > cannot test anything else anyways. > > > > > > [...] > > > > Applied, thanks! > > > > [2/2] arm64: dts: rockchip: rk3588: add PCIe3 support > > commit: 0acf4fa7f187cd7e3dad93f1ee14e9509687621e > > Applying this without the PCIe 2 series being applied introduces > warnings for the RK3588 dtbs_check, as mentioned in the second > setence of the text you quoted :) > > (FWIW RK356x already has the same warnings, though) darn, I didn't do a full binding check, only a "compiles" check after applying. We're at rc3 now, so I would hope that the pcie2 binding changes get applied soon'ish so I can then also pick up the dts change from there. Heiko
