On Mon, Jul 24, 2023 at 05:26:24PM -0600, Rob Herring wrote: > On Mon, Jul 24, 2023 at 06:23:13PM +0100, Conor Dooley wrote: > > On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote: > > > The snps dwmac IP support safety features, and those Safety Feature > > > Correctible Error and Uncorrectible Error irqs may be separate irqs. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index ddf9522a5dc2..bb80ca205d26 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -107,6 +107,8 @@ properties: > > > - description: Combined signal for various interrupt events > > > - description: The interrupt to manage the remote wake-up packet detection > > > - description: The interrupt that occurs when Rx exits the LPI state > > > + - description: The interrupt that occurs when Safety Feature Correctible Errors happen > > > + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > > > > > interrupt-names: > > > minItems: 1 > > > @@ -114,6 +116,8 @@ properties: > > > - const: macirq > > > - enum: [eth_wake_irq, eth_lpi] > > > - const: eth_lpi > > > + - const: sfty_ce_irq > > > + - const: sfty_ue_irq > > > > Putting _irq in an interrupt name seems rather redundant to me although, > > clearly not the first time for it here. > > It's already inconsistent, so don't follow that pattern. Drop '_irq'. Thanks for the suggestion, will wait a bit to get more feedbacks before sending out v2. > > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > Thanks, > > Conor. > >
