Re: [PATCH] arm64: dts: imx8mn: Drop CSI1 PHY reference clock configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 24, 2023 at 5:22 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> The CSI1 PHY reference clock are limited to 125 MHz according to:
> i.MX 8M Nano Applications Processor Reference Manual, Rev. 2, 07/2022
> Table 5-1. Clock Root Table (continued) / page 319
> Slice Index n = 123 .
>
> Currently those IMX8MN_CLK_CSI1_PHY_REF clock are configured to be
> fed directly from 1 GHz PLL2 , which overclocks them . Instead, drop
> the configuration altogether, which defaults the clock to 24 MHz REF
> clock input, which for the PHY reference clock is just fine.
>
> Fixes: ae9279f301b5 ("arm64: dts: imx8mn: Add CSI and ISI Nodes")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>

Reviewed-by: Adam Ford <aford173@xxxxxxxxx>

> ---
> Cc: Adam Ford <aford173@xxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Li Jun <jun.li@xxxxxxx>
> Cc: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 9869fe7652fca..aa38dd6dc9ba5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -1175,10 +1175,8 @@ mipi_csi: mipi-csi@32e30000 {
>                                 compatible = "fsl,imx8mm-mipi-csi2";
>                                 reg = <0x32e30000 0x1000>;
>                                 interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> -                               assigned-clocks = <&clk IMX8MN_CLK_CAMERA_PIXEL>,
> -                                                 <&clk IMX8MN_CLK_CSI1_PHY_REF>;
> -                               assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_1000M>,
> -                                                         <&clk IMX8MN_SYS_PLL2_1000M>;
> +                               assigned-clocks = <&clk IMX8MN_CLK_CAMERA_PIXEL>;
> +                               assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_1000M>;
>                                 assigned-clock-rates = <333000000>;
>                                 clock-frequency = <333000000>;
>                                 clocks = <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> --
> 2.40.1
>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux