On Mon, Jul 24, 2023 at 04:59:27PM +0530, MD Danish Anwar wrote:
> Add icssg_config.h / .c and icssg_classifier.c files. These are firmware
> configuration and classification related files. These will be used by
> ICSSG ethernet driver.
>
> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Hi Danish,
some feedback from my side.
...
> diff --git a/drivers/net/ethernet/ti/icssg_classifier.c b/drivers/net/ethernet/ti/icssg_classifier.c
...
> +void icssg_class_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac)
This function appears to be unused.
Perhaps it would be better placed in a later patch?
Or perhaps not, if it makes it hard to split up the patches nicely.
In which case, perhaps the __maybe_unused annotation could be added,
temporarily.
Flagged by clang-16 W=1, and gcc=12 W=1 builds.
Likewise for other issues flagged below regarding
function declarations/definitions.
> +{
> + regmap_write(miig_rt, offs[slice].mac0, (u32)(mac[0] | mac[1] << 8 |
> + mac[2] << 16 | mac[3] << 24));
> + regmap_write(miig_rt, offs[slice].mac1, (u32)(mac[4] | mac[5] << 8));
> +}
> +
> +/* disable all RX traffic */
> +void icssg_class_disable(struct regmap *miig_rt, int slice)
This function is only used in this file.
Please consider making it static.
...
> +void icssg_class_default(struct regmap *miig_rt, int slice, bool allmulti)
This function also appears to be unused.
...
> +/* required for SAV check */
> +void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr)
This function also appears to be unused.
...
> diff --git a/drivers/net/ethernet/ti/icssg_config.c b/drivers/net/ethernet/ti/icssg_config.c
...
> +void icssg_config_ipg(struct prueth_emac *emac)
This function is also only used in this file.
...
> +static void icssg_init_emac_mode(struct prueth *prueth)
> +{
> + /* When the device is configured as a bridge and it is being brought
> + * back to the emac mode, the host mac address has to be set as 0.
> + */
> + u8 mac[ETH_ALEN] = { 0 };
> +
> + if (prueth->emacs_initialized)
> + return;
> +
> + regmap_update_bits(prueth->miig_rt, FDB_GEN_CFG1,
> + SMEM_VLAN_OFFSET_MASK, 0);
> + regmap_write(prueth->miig_rt, FDB_GEN_CFG2, 0);
> + /* Clear host MAC address */
> + icssg_class_set_host_mac_addr(prueth->miig_rt, mac);
icssg_class_set_host_mac_addr() is defined in icssg_classifier.c
but used here in icssg_config.c.
Please consider providing a declaration of this function,
ideally in a .h file.
...
> +int emac_set_port_state(struct prueth_emac *emac,
> + enum icssg_port_state_cmd cmd)
This function also appears to be unused.
...
> +void icssg_config_set_speed(struct prueth_emac *emac)
Ditto.
...
