On Fri, Jul 21, 2023 at 04:20:40PM -0500, nick.hawkins@xxxxxxx wrote: > From: Nick Hawkins <nick.hawkins@xxxxxxx> > > Provide access to the register regions and interrupt for Universal > MAC(UMAC). The driver under the hpe,gxp-umac-mdio will provide an > interface for managing both the internal and external PHYs. > > Signed-off-by: Nick Hawkins <nick.hawkins@xxxxxxx> > --- > .../bindings/net/hpe,gxp-umac-mdio.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/hpe,gxp-umac-mdio.yaml > > diff --git a/Documentation/devicetree/bindings/net/hpe,gxp-umac-mdio.yaml b/Documentation/devicetree/bindings/net/hpe,gxp-umac-mdio.yaml > new file mode 100644 > index 000000000000..bb0db1bb67b1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/hpe,gxp-umac-mdio.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/hpe,gxp-umac-mdio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP UMAC MDIO Controller > + > +maintainers: > + - Nicholas Hawkins <nick.hawkins@xxxxxxx> > + > +description: |+ You've got no formatting to preserve, so even | on its own would be wasted here. > + The HPE GXP Unversal MAC (UMAC) MDIO controller provides a configuration > + path for both external PHY's and SERDES connected PHY's. > + > +allOf: > + - $ref: mdio.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-umac-mdio > + > + reg: > + maxItems: 1 > + description: The register range of the MDIO controller instance This is a statement of the obvious, no? Otherwise, looks okay to me. Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + mdio0: mdio@4080 { > + compatible = "hpe,gxp-umac-mdio"; > + reg = <0x4080 0x10>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + phy-mode = "sgmii"; > + reg = <0>; > + }; > + }; > -- > 2.17.1 >
Attachment:
signature.asc
Description: PGP signature
