Dear Jim,
Am 24.07.23 um 05:04 schrieb Jim Liu:
sorry for reply late.
No problem. Thank you for your reply. Some minor comments below.
First, thanks for your review.
the description is as below:
The SGPIO module can be programmed to support from zero (none) to
eight external output ports ,
No space before the comma.
each with eight output pins (for a total of 64 output pins). The
output ports must be serial-to-parallel devices (such as the HC595 or
a faster equivalent).
The SGPIO can be programmed to accept from zero to eight external
input ports (IXPp), each with eight input pins, supporting a total of
64 input pins. The input ports must be parallel-to-serial devices
(such as the HC165 or a faster equivalent).
you can add hc595 and hc165 ic to get the serial data from BMC and
send serial data to BMC.
This driver can expand extra gpio pins up to 64 input and 64 output.
One space before “extra”. Maybe:
hc595 and c165 ic allow to transmit serial data from and to the BMC.
This driver can expand extra GPIO pins up to 64 inputs and 64 outputs.
i will use jim.t90615@xxxxxxxxx this mail to upstream this driver not
company mail.
If this is paid work, using your company email address should be
preferred in my opinion.
The driver needs to fix the length of the variables, because the reg
size is one byte.
One byte would also fit into `unsigned int`, wouldn’t it?
I will follow your suggestion to modify and upstream again. If you
have any questions please let me know.
If you could use Mozilla Thunderbird to reply easily in interleaved
style, that would great.
Otherwise, I am looking forward to the next revision.
Kind regards,
Paul
