Hi, Andy Thank you very much for your advice! I have re-made my patches based on your suggestion. > -----Original Message----- > From: Andi Shyti <andi.shyti@xxxxxxxxxx> > Sent: Wednesday, June 14, 2023 6:42 AM > To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Cc: Carlos Song <carlos.song@xxxxxxx>; Aisheng Dong > <aisheng.dong@xxxxxxx>; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > Anson.Huang@xxxxxxx; Clark Wang <xiaoning.wang@xxxxxxx>; Bough Chen > <haibo.chen@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > linux-i2c@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [EXT] Re: [PATCH 2/2] dt-bindings: i2c: imx-lpi2c: Add bus recovery > example > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report this > email' button > > > Hi, > > > > We also find the sci-gpio and sda-gpio have been defined in the ref: > /schemas/i2c/i2c-controller.yaml. > > > So is this the root cause of no need to add these properties? > > > > Yes. > > is some cleanup needed also in i2c-imx.yaml? > Carlos: I will not upstream any patch for i2c-imx.yaml. I will drop it. > Andi