On 23. 7. 15. 02:44, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > drivers/devfreq/imx-bus.c | 2 +- > drivers/devfreq/imx8m-ddrc.c | 2 +- > drivers/devfreq/mtk-cci-devfreq.c | 1 - > drivers/devfreq/tegra30-devfreq.c | 2 +- > 4 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c > index a727067980fb..86850b7dea09 100644 > --- a/drivers/devfreq/imx-bus.c > +++ b/drivers/devfreq/imx-bus.c > @@ -7,7 +7,7 @@ > #include <linux/devfreq.h> > #include <linux/device.h> > #include <linux/module.h> > -#include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/pm_opp.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c > index 16636973eb10..e1348490c8aa 100644 > --- a/drivers/devfreq/imx8m-ddrc.c > +++ b/drivers/devfreq/imx8m-ddrc.c > @@ -3,9 +3,9 @@ > * Copyright 2019 NXP > */ > > +#include <linux/mod_devicetable.h> > #include <linux/module.h> > #include <linux/device.h> > -#include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/devfreq.h> > #include <linux/pm_opp.h> > diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c > index 6354622eda65..83a73f0ccd80 100644 > --- a/drivers/devfreq/mtk-cci-devfreq.c > +++ b/drivers/devfreq/mtk-cci-devfreq.c > @@ -8,7 +8,6 @@ > #include <linux/minmax.h> > #include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/pm_opp.h> > #include <linux/regulator/consumer.h> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 503376b894b6..4a4f0106ab9d 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -13,7 +13,7 @@ > #include <linux/io.h> > #include <linux/irq.h> > #include <linux/module.h> > -#include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/pm_opp.h> > #include <linux/reset.h> Looks good to me. But, need to change the patch title with 'PM / ' prefix to keep the consistency of previous devfreq patch and then this patch touched the other devfreq drivers except for imx drivers. So that I think that it is better to change the patch title as following and then applied it. Thanks. - "PM / devfreq: Explicitly include correct DT includes" -- Best Regards, Samsung Electronics Chanwoo Choi
