Hi Xiaolei, On Sat, Jul 22, 2023 at 11:21 PM Xiaolei Wang <xiaolei.wang@xxxxxxxxxxxxx> wrote: > > If the tuning step is not set, the tuning step is set to 1. > For some sd cards, the following Tuning timeout will occur, You missed putting the timeout message here. > so set the default tuning step. This refers to the NXP vendor's > commit below: > > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/ > arch/arm/boot/dts/imx7s.dtsi#L1216-L1217 > > Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting") > Signed-off-by: Xiaolei Wang <xiaolei.wang@xxxxxxxxxxxxx> > > v2: > * Refer to https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217 > and add the following attributes for all usdhc of imx7: > fsl,tuning-step = <2>; > fsl,tuning-start-tap = <20>; This v2 changelog should be placed below the --- line. > --- Put it here. Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
