On Tue, Jul 18, 2023 at 07:37:21PM +0200, Greg KH wrote:
> On Tue, Jul 18, 2023 at 10:09:41PM +0530, Yogesh Hegde wrote:
> > This patch fixes an issue affecting the Wifi/Bluetooth connectivity on
> > ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth
> > on ROCK Pi 4 boards") introduced a problem with the clock configuration.
> > Specifically, the clock-names property of the sdio-pwrseq node was not
> > updated to 'lpo', causing the driver to wait indefinitely for the wrong clock
> > signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper
> > initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.
> >
> > To address this, this patch updates the clock-names property of the
> > sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node.
> >
> > This patch has been tested on ROCK Pi 4B.
> >
> > Fixes: f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
> > Signed-off-by: Yogesh Hegde <yogi.kernel@xxxxxxxxx>
>
> Why are you saying this fixes a specific old commit and not also
> properly cc: the stable@xxxxxxxxxxxxxxx alias?
It is a mistake on my part. I apologize for the mistake.
>
> Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
Thanks for the link, I will read through it and resend a v3 of the patch
with fixes.
Thanks and Regards
-- Yogesh
