Hi Manivannan, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam/dt-bindings-ufs-common-add-OPP-table/20230720-134720 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230720054100.9940-9-manivannan.sadhasivam%40linaro.org patch subject: [PATCH v2 08/15] OPP: Introduce dev_pm_opp_get_freq_indexed() API config: i386-randconfig-m041-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210431.3S4SeXVw-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210431.3S4SeXVw-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202307210431.3S4SeXVw-lkp@xxxxxxxxx/ New smatch warnings: drivers/opp/core.c:213 dev_pm_opp_get_freq_indexed() warn: variable dereferenced before IS_ERR check 'opp' (see line 211) Old smatch warnings: drivers/opp/core.c:254 dev_pm_opp_get_required_pstate() warn: variable dereferenced before IS_ERR check 'opp' (see line 252) drivers/opp/core.c:2458 _opp_attach_genpd() warn: passing zero to 'PTR_ERR' vim +/opp +213 drivers/opp/core.c a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 209 unsigned long dev_pm_opp_get_freq_indexed(struct dev_pm_opp *opp, u32 index) a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 210 { a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 @211 struct opp_table *opp_table = opp->opp_table; ^^^^^^^^^^^^^^^ Dereference a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 212 a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 @213 if (IS_ERR_OR_NULL(opp) || index >= opp_table->clk_count) { ^^^ Checked too late a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 214 pr_err("%s: Invalid parameters\n", __func__); This should be a dev_err(), btw. a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 215 return 0; a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 216 } a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 217 a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 218 return opp->rates[index]; a772c36cb3fb41 drivers/opp/core.c Manivannan Sadhasivam 2023-07-20 219 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
