Hi Danish, On 20/07/2023 14:42, Md Danish Anwar wrote: > Hi Jakub, > > On 20/07/23 10:05 am, Jakub Kicinski wrote: >> The patch is too big to review. >> >> Please break it apart separating into individual features, targeting >> around 10 patches in the series. That will make it easier for reviewers >> to take a look at the features in which they have expertise. >> > > Sure Jakub. I will try to break this patch in multiple patches as below. > > Patch 1: Introduce Firmware mapping for the driver (icss_switch_map.h) > > Patch 2: Introduce mii helper APIs. (icssg_mii_rt.h and icssg_mii_cfg.h). This > patch will also introduce basic prueth and emac structures in icssg_prueth.h as > these structures will be used by the helper APIs. > > Patch 3: Introduce firmware configuration and classification APIs. > (icssg_classifier.c, icssg_config.h and icssg_config.c) > > Patch 4: Introduce APIs for ICSSG Queues (icssg_queues.c) > > Patch 5: Introduce ICSSG Ethernet driver. (icssg_prueth.c and icssg_prueth.h) > This patch will enable the driver and basic functionality can work after this > patch. This patch will be using all the APIs introduced earlier. This patch > will also include Kconfig and Makefile changes. DT binding documentation patch can come here. > > Patch 6: Enable standard statistics via ndo_get_stats64 > > Patch 7: Introduce ethtool ops for ICSSG > > Patch 8: Introduce power management support (suspend / resume APIs) > <snip> -- cheers, -roger
