On Thu, Jul 20, 2023 at 02:29:28PM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on > > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> This is awesome, thank you! > > #include <linux/bits.h> > #include <linux/module.h> > +#include <linux/of.h> Are you sure you need this? I think the only OF-specific structure that is being used is of_device_id, which comes from mod_devicetable.h that you include below. Otherwise: Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Please feel free to merge with the rest of the series. Thanks. -- Dmitry
