Hi,
Krzysztof:
On Wed, Jul 19, 2023 at 11:44:45AM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2023 11:24, alina_yu@xxxxxxxxxxx wrote:
> > From: alinayu <alina_yu@xxxxxxxxxxx>
> >
> > Add bindings for Richtek RTQ2208 IC controlled SubPMIC
> >
> > Signed-off-by: Alina Yu <alina_yu@xxxxxxxxxxx>
> > ---
> > v4
> > - Modify filename to "richtek,rtq2208"
> > - Add more desciptions for "regulator-allowed-modes"
...
> > +
> > + regulator-mode:
> > + enum: [0, 1]
> > + description:
> > + describe buck initial operating mode in suspend state.
>
> There is no such property on this level. Aren't you mixing initial one?
It's the initial mode in suspend-mem state, should I modify that like this ?
patternProperties:
"^regulator-state-(standby|mem|disk)$":
type: object
$ref: regulator.yaml#
properties:
regulator-mode:
enum: [0, 1]
description:
describe byck initial operating mode in suspend state.
...
>
> > + enum: [ 900000, 1200000, 1800000, 3300000 ]
> > + description:
> > + the fixed voltage in micro volt which is decided at the factory.
>
> I don't understand this property. Why this is different from min/max
Because ldo has fixed voltage, so I thinks I could use a property to
represent the fixed voltage directly. Do you suggest me modifying that like this:
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <900000>;
Using min voltage equals to max voltage to represent fixed voltage, instead of self-defined property ?
> microvolt? Plus, you use incorrect unit suffix.
if I change "richtek,fixed-uV" to "richtek, fixed-microvolt",
will it be a correct unit suffix ?
Best regards,
Alina
