On Wed, Jul 19, 2023 at 06:49:43AM +0000, Potthuri, Sai Krishna wrote: > Hi Conor, > > > -----Original Message----- > > From: Conor Dooley <conor@xxxxxxxxxx> > > Sent: Tuesday, July 18, 2023 9:20 PM > > To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Simek, Michal > > <michal.simek@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof > > Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley > > <conor+dt@xxxxxxxxxx>; Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>; Shah, > > Tanmay <tanmay.shah@xxxxxxx>; Levinsky, Ben <ben.levinsky@xxxxxxx>; > > Marek Vasut <marex@xxxxxxx>; Roman Gushchin <roman.gushchin@xxxxxxxxx>; > > Arnd Bergmann <arnd@xxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx> > > Subject: Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable > > configuration > > > > On Mon, Jul 17, 2023 at 03:03:46PM +0530, Sai Krishna Potthuri wrote: > > > Add 'output-enable' configuration parameter to the properties list. > > > > > > Using these pinctrl properties observed hang issues with older Xilinx > > > ZynqMP Platform Management Firmware, hence reverted the patch previously. > > > Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add > > > output-enable configuration""). > > > > And what has changed since then that makes it okay to add? > > Is the old firmware not still in the wild? > This time when Linux firmware driver get the request for TRISTATE configuration > from pinctrl driver, it checks if that configuration is supported by the Xilinx ZynqMP > Platform Management firmware. If yes, then calls will be made otherwise it returns error. Please put that information in your commit message. With that done, Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature