Hi, Krzysztof, On Wed, Jul 19, 2023 at 09:43:03AM +0200, Krzysztof Kozlowski wrote: > On 19/07/2023 06:25, alina_yu@xxxxxxxxxxx wrote: > > From: alinayu <alina_yu@xxxxxxxxxxx> > > > > Add bindings for Richtek RTQ2208 IC controlled SubPMIC > > > > Signed-off-by: Alina Yu <alina_yu@xxxxxxxxxxx> > > --- > > v3 > > - Fix some typos > > - Modify the descriptions for "richtek,mtp-sel" > > - Modify the node name to lowercase and remove underscore > > - Remove '|' from description > > - Remove "regulator-compatible" from property > > - Remove "regulator-state-mem" from pattern > > - Modify node name to generic one > > --- > > .../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++ > > 1 file changed, 206 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml > > new file mode 100644 > > index 0000000..2fc92e5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml > > No improvements here. > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof > Sorry, I missed this one "Filename like compatible". If I modify the filename to "richtek,rtq2208.yaml", is it unlike a compatible ? Best regards, Alina
