Re: [PATCH] arm64: dts: qcom: sdm630: remove refs to nonexistent clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.07.2023 10:39, Krzysztof Kozlowski wrote:
On 19/07/2023 09:35, Alexey Minnekhanov wrote:
Since commit d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out
interconnect bus clocks") rpmcc-sdm660 no longer provides
RPM_SMD_AGGR2_NOC_CLK and RPM_SMD_AGGR2_NOC_A_CLK clocks.
Remove them to fix various probe failures and get devices
booting again.

So that commit broke DTS?


Yes, this is my understanding of the situation.
The commit in subject [1] is only in linux-next for a few days, so it broke booting only on 6.5-rc (rc2 currently). Konrad said: "these clocks references were API abuses; referencing the bus clocks was circumventing the interconnect layer. That loophole is now gone and the abusers are now apparent"


It does not look like you tested the DTS against bindings. Please run
`make dtbs_check`


If DT schema for interconnect requires bus clocks to be specified, I don't even know what to put there now. Can we change schema?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d6edc31f3a68d8d0636e0cfcd9eced7460ad32f4

--
Regards,
Alexey Minnekhanov
postmarketOS developer



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux