Hi Rob,
Do you have any comment on this?
Thanks,
Lizhi
On 6/30/23 11:24, Lizhi Hou wrote:
On 6/29/23 16:52, Rob Herring wrote:
+ rp[i].child_addr[0] = j;
+ ret = of_changeset_add_empty_prop(ocs, np, "dynamic");
It seems slightly confusing to use a "dynamic" property here when we
also have the OF_DYNAMIC dynamic flag above. I think they have
different meanings, don't they?
Hum, what's the property for? It's new in this version. Any DT property
needs to be documented, but I don't see why we need it.
This is mentioned in my previous reply for V9
https://lore.kernel.org/lkml/af9b6bb3-a98d-4fb6-b51e-b48bca61dada@xxxxxxx/
As we discussed before, "interrupt-map" was intended to be used here.
And after thinking it more, it may not work for the cases where ppnode
is not dynamically generated and it does not have "interrupt-map".
For example the IBM ppc system, its device tree has nodes for pci bridge
and it does not have "interrupt-map".
Based on previous discussions, OF_DYNAMIC should not be used here.
So I think adding "dynamic" might be a way to identify the dynamically
added node. Or we can introduce a new flag e.g OF_IRQ_SWIZZLING.
Thanks,
Lizhi
