On 18/07/2023 15:08, Krzysztof Kozlowski wrote:
On 18/07/2023 14:47, Matthew Croughan wrote:
Mango Pi MQ Quad is a H616 based SBC, add basic support for the board
and its peripherals
---
Third email within few hours - no, wait a day. There are so many issues
here that sending immediately won't help you.
1. Missing changelog, so did you ignore entire feedback?
2. Missing Signed-off-by
arch/arm64/boot/dts/allwinner/Makefile | 1 +
.../allwinner/sun50i-h616-mangopi-mq-quad.dts | 183 ++++++++++++++++++
Yeah, no bindings patch, so you did ignore the feedback.
Sorry, that's a no.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
No problem, this is my first attempt at contribution to the kernel, and
my first time trying to follow the process on
https://docs.kernel.org/process/submitting-patches.html. The first reply
attempting to address your feedback, I screwed up and didn't add -v2 to
git format-patch. I wasn't sure if I'd get yelled at for that, so I
panicked and sent with the -v2 to correct it afterwards, hoping you'd
ignore it. It appears I've made it worse, spam was not the intent.
Please let me know if I've replied to this email with good etiquette
also, as I'm told I shouldn't be "top-posting". But I was born after
Email was obsolete, so am not sure if I'm doing it correctly.
Changelog: I'm sorry, I missed the part of submitting-patches.html that
said it would be good for other reviewers. I'll try making a changelog
on my next submission.
Bindings: I just figured out that you meant I should add to the
`Documentation` folder, and that you were not suggesting the dt-bindings
in the #includes were inaccurate or missing.
