On Mon, Jul 17, 2023 at 05:19:11PM +0200, Konrad Dybcio wrote:
> The GCC block on SM6375 is powered by the VDD_CX rail. We need to ensure
> that it's enabled to prevent unwanted power collapse.
This bit is not correct either (and similar throughout the series).
> Enable runtime PM to keep the power flowing only when necessary.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> + ret = pm_runtime_resume_and_get(&pdev->dev);
> + if (ret)
> + return ret;
> +
> regmap = qcom_cc_map(pdev, &gcc_sm6375_desc);
> - if (IS_ERR(regmap))
> + if (IS_ERR(regmap)) {
> + pm_runtime_put(&pdev->dev);
> return PTR_ERR(regmap);
> + }
>
> ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_dfs_clocks));
> if (ret)
Looks like you forgot to update this error path.
> @@ -3817,7 +3828,10 @@ static int gcc_sm6375_probe(struct platform_device *pdev)
> clk_lucid_pll_configure(&gpll8, regmap, &gpll8_config);
> clk_zonda_pll_configure(&gpll9, regmap, &gpll9_config);
>
> - return qcom_cc_really_probe(pdev, &gcc_sm6375_desc, regmap);
> + ret = qcom_cc_really_probe(pdev, &gcc_sm6375_desc, regmap);
> + pm_runtime_put(&pdev->dev);
> +
> + return ret;
Johan
