On 18/07/2023 13:21, William-tw Lin wrote: > dt-binding documentation for mtk-socinfo driver. > mtk-socinfo driver provides SoC-related information. > Such information includes manufacturer information, SoC name, > SoC segment name, and SoC marketing name. > > Signed-off-by: William-tw Lin <william-tw.lin@xxxxxxxxxxxx> > --- > .../bindings/soc/mediatek/mtk-socinfo.yaml | 58 +++++++++++++++++++ Put it in appropriate place - hwinfo. > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml Wrong filename: missing vendor prefix, not matching compatibles. > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml > new file mode 100644 > index 000000000000..4420430a9bca > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mediatek/mtk-socinfo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SOC information > + > +maintainers: > + - William Lin <william-tw.lin@xxxxxxxxxxxx> > + - Matthias Brugger <matthias.bgg@xxxxxxxxx> > + - Kevin Hilman <khilman@xxxxxxxxxx> > + > +description: > + The MTK socinfo driver can retrieve several Driver? As in Linux driver? Drop. Describe hardware instead. > + SoC related information based on settings in eFuse. > + Such information include manufacturer information, SoC name, > + SoC segment name, and SoC marketing name. > + > + Just one blank line. > +properties: > + compatible: > + enum: > + - mediatek,mt8173-socinfo > + - mediatek,mt8183-socinfo > + - mediatek,mt8186-socinfo > + - mediatek,mt8188-socinfo > + - mediatek,mt8192-socinfo > + - mediatek,mt8195-socinfo > + > + Ditto... > + nvmem-cells: > + description: > + Phandle to the eFuse data for SoC differentiation. > + items: > + - description: eFuse data that mtk-socinfo driver uses for SoC differentiation > + > + nvmem-cell-names: > + minItems: 1 > + items: > + - const: socinfo-data1 > + - const: socinfo-data2 This does not match your cells. > + > +required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + mtk_socinfo: socinfo { Broken indentation. > + compatible = "mediatek,mt8186-socinfo"; > + nvmem-cells = <&socinfo_data1>; > + nvmem-cell-names = "socinfo-data1"; No other resources? So this is just DT description of driver? Does not look like suitable for DT in the first place. Best regards, Krzysztof
