On 18/07/2023 09:59, Fenglin Wu wrote: >>> Just FYI,the change log was updated in the cover letter here: >>> https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@xxxxxxxxxxx/T/#m3819b50503ef19e0933a10bf797351a4af35537f >>> >>> Also the commit text and the driver change were also updated accordingly >>> to address your review comment by removing 'pm7550ba-vib' compatible string. >> >> Removing compatible was never my feedback. Did you read: >> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 >> ? >> > Okay, so do you want me to add 'pm7550ba-vib' as a fallback compatible > like this? > > properties: > compatible: > - enum: > - - qcom,pm8058-vib > - - qcom,pm8916-vib > - - qcom,pm8921-vib > - - qcom,pmi632-vib > - - qcom,pm7250b-vib > - - qcom,pm7325b-vib > + oneOf: > + - enum: > + - qcom,pm8058-vib > + - qcom,pm8916-vib > + - qcom,pm8921-vib > + - qcom,pmi632-vib > + - qcom,pm7250b-vib > + - qcom,pm7325b-vib > + - items: > + - enum: > + - qcom,pm7550ba-vib > + - const: qcom,pm7325b-vib > Yes Best regards, Krzysztof
