Chih-Jen Hung <kobedylan@xxxxxxxxx> 於 2023年7月18日 週二 上午9:59寫道: > > On Mon, Jul 17, 2023 at 02:58:58PM +0800, Dylan Hung wrote: > > Add reset definitions of AST2600 I3C and MAC controllers. > > Signed-off-by: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx> > --- > include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > > What changed compared to v1? > Are there any users of the additional resets (eg, in a dts somewhere)? > > Thanks, > Conor. An existing macro, ASPEED_RESET_I3C_DMA, was removed in V1. However, considering that this macro may be used somewhere, I have decided to add it back in V2. I will ensure to include the changelog in V3. > > > diff --git a/include/dt-bindings/clock/ast2600-clock.h > b/include/dt-bindings/clock/ast2600-clock.h > index e149eee61588..712782177c90 100644 > --- a/include/dt-bindings/clock/ast2600-clock.h > +++ b/include/dt-bindings/clock/ast2600-clock.h > @@ -90,7 +90,19 @@ > /* Only list resets here that are not part of a clock gate + reset pair */ > #define ASPEED_RESET_ADC 55 > #define ASPEED_RESET_JTAG_MASTER2 54 > + > +#define ASPEED_RESET_MAC4 53 > +#define ASPEED_RESET_MAC3 52 > + > +#define ASPEED_RESET_I3C5 45 > +#define ASPEED_RESET_I3C4 44 > +#define ASPEED_RESET_I3C3 43 > +#define ASPEED_RESET_I3C2 42 > +#define ASPEED_RESET_I3C1 41 > +#define ASPEED_RESET_I3C0 40 > +#define ASPEED_RESET_I3C 39 > #define ASPEED_RESET_I3C_DMA 39 This is the macro I added back in V2. There is no reset-line hardware available for `ASPEED_RESET_I3C_DMA`, so I have added a new macro to provide a better representation of the hardware design. I will include the explanation in the commit message of V3. > + > #define ASPEED_RESET_PWM 37 > #define ASPEED_RESET_PECI 36 > #define ASPEED_RESET_MII 35 > -- > 2.25.1