On 23-07-17, Krzysztof Kozlowski wrote: > On 17/07/2023 18:51, Marco Felsch wrote: > > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > > corresponding bindings by adding an own entry for it. Mark > > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > > we already have a user for it [1]. > > > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > > boards/polyhex-debix/board.c#L38 > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > Subject: fix is too generic and binding is redundant. You already state > this is binding in your prefix. Describe more precise what you are doing. > > > --- > > Changelog: > > > > v2: > > - deprecate polyhex,imx8mp-debix > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 15d4110840654..b29974e3c30b3 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -1019,8 +1019,6 @@ properties: > > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > > - fsl,imx8mp-evk # i.MX8MP EVK Board > > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > > - - polyhex,imx8mp-debix # Polyhex Debix boards > > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > > @@ -1054,6 +1052,14 @@ properties: > > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > > - const: fsl,imx8mp > > > > + - description: Polyhex DEBIX i.MX8MP based SBCs > > + items: > > + - enum: > > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > > + deprecated: true > > + - const: fsl,imx8mp > > That's not how it works and it does not look like you tested the DTS > against bindings. Please run `make dtbs_check` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Don't deprecate some piece of entire compatible list, but entire list. > > The commit which deprecates compatible should bring a proper one. What did you mean by that? Regards, Marco > Otherwise at this point we have kernel only with deprecated compatibles. > > > Best regards, > Krzysztof > > >
