On Mon, Jul 17, 2023 at 4:27 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sun, Jul 16, 2023 at 3:26 AM Heiko Stuebner <heiko@xxxxxxxxx> wrote: > > > > Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > > > The DT of_device.h and of_platform.h date back to the separate > > > of_platform_bus_type before it as merged into the regular platform bus. > > > As part of that merge prepping Arm DT support 13 years ago, they > > > "temporarily" include each other. They also include platform_device.h > > > and of.h. As a result, there's a pretty much random mix of those include > > > files used throughout the tree. In order to detangle these headers and > > > replace the implicit includes with struct declarations, users need to > > > explicitly include the correct includes. > > > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > > [...] > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > index 917e79951aac..2744d8f4a6fa 100644 > > > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > @@ -12,7 +12,9 @@ > > > #include <linux/mfd/syscon.h> > > > #include <linux/module.h> > > > #include <linux/of_device.h> > > > +#include <linux/of_platform.h> > > > #include <linux/phy/phy.h> > > > +#include <linux/platform_device.h> > > > #include <linux/pm_runtime.h> > > > #include <linux/regmap.h> > > > > I'm not sure if I'm just misreading something, but in all other places > > of_device.h gets removed while here is stays as an include. Is this > > correct this way? > > Yes, because of_match_device() is used. > > Rob > For drivers/gpu/drm/bridge/ Acked-by: Robert Foss <rfoss@xxxxxxxxxx>
