Hi Rob, Thanks for your review! On Thu, Jun 22, 2023 at 4:52 PM Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Jun 22, 2023 at 11:21:13AM +0200, Geert Uytterhoeven wrote: > > Add device tree bindings for the LCD Controller (LCDC) found in Renesas > > SuperH SH-Mobile and ARM SH/R-Mobile SOCs. > > > > Based on a plain text prototype by Laurent Pinchart. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml > > @@ -0,0 +1,108 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/renesas,shmobile-lcdc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas SH-Mobile LCD Controller (LCDC) > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,r8a7740-lcdc # R-Mobile A1 > > + - renesas,sh73a0-lcdc # SH-Mobile AG5 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 5 > > + description: > > + Only the functional clock is mandatory. > > + Some of the optional clocks are model-dependent (e.g. "video" (a.k.a. > > + "vou" or "dv_clk") is available on R-Mobile A1 only). > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 5 > > + items: > > + enum: [ fck, media, lclk, hdmi, video ] > > + > > + power-domains: > > + maxItems: 1 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + description: | > > + The connections to the output video ports are modeled using the OF graph > > + bindings specified in Documentation/devicetree/bindings/graph.txt. > > Please read this file. > > > + The number of ports and their assignment are model-dependent. > > + Each port shall have a single endpoint. > > I'd just drop the whole description. > > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: LCD port (R-Mobile A1 and SH-Mobile AG5) > > + unevaluatedProperties: false > > Don't need this. You mean the "unevaluatedProperties: false"? Or more? Thanks again! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
