Re: [PATCH v2 01/19] clk: meson: introduce meson-clkc-utils

[Neil Armstrong <neil.armstrong@xxxxxxxxxx>]

On 12/07/2023 14:03, Jerome Brunet wrote:
> On Mon 12 Jun 2023 at 11:57, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
>
> > Let's introduce a new module called meson-clkc-utils that
> > will contain shared utility functions for all Amlogic clock
> > controller drivers.
> >
> > The first utility function is a replacement of of_clk_hw_onecell_get
> > in order to get rid of the NR_CLKS define in all Amlogic clock
> > drivers.
> >
> > The goal is to move all duplicate probe and init code in this module.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>
> Hi Neil,
>
> checkpatch complains about the MODULE_LICENSE()
>
> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
> #185: FILE: drivers/clk/meson/meson-clkc-utils.c:25:
> +MODULE_LICENSE("GPL v2");

Damn, sorry for that

> I don't mind fixing this up while applying if it is Ok with you.

Yes please, I'm OoO and won't be able to send a v3 soonish.

Thanks,
Neil

> > ---
> >   drivers/clk/meson/Kconfig            |  3 +++
> >   drivers/clk/meson/Makefile           |  1 +
> >   drivers/clk/meson/meson-clkc-utils.c | 25 +++++++++++++++++++++++++
> >   drivers/clk/meson/meson-clkc-utils.h | 19 +++++++++++++++++++
> >   4 files changed, 48 insertions(+)
> >
> > diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> > index 8ce846fdbe43..d03adad31318 100644
> > --- a/drivers/clk/meson/Kconfig
> > +++ b/drivers/clk/meson/Kconfig
> > @@ -30,6 +30,9 @@ config COMMON_CLK_MESON_VID_PLL_DIV
> >   	tristate
> >   	select COMMON_CLK_MESON_REGMAP
> >   
> > +config COMMON_CLK_MESON_CLKC_UTILS
> > +	tristate
> > +
> >   config COMMON_CLK_MESON_AO_CLKC
> >   	tristate
> >   	select COMMON_CLK_MESON_REGMAP
> > diff --git a/drivers/clk/meson/Makefile b/drivers/clk/meson/Makefile
> > index d5288662881d..cd961cc4f4db 100644
> > --- a/drivers/clk/meson/Makefile
> > +++ b/drivers/clk/meson/Makefile
> > @@ -1,6 +1,7 @@
> >   # SPDX-License-Identifier: GPL-2.0-only
> >   # Amlogic clock drivers
> >   
> > +obj-$(CONFIG_COMMON_CLK_MESON_CLKC_UTILS) += meson-clkc-utils.o
> >   obj-$(CONFIG_COMMON_CLK_MESON_AO_CLKC) += meson-aoclk.o
> >   obj-$(CONFIG_COMMON_CLK_MESON_CPU_DYNDIV) += clk-cpu-dyndiv.o
> >   obj-$(CONFIG_COMMON_CLK_MESON_DUALDIV) += clk-dualdiv.o
> > diff --git a/drivers/clk/meson/meson-clkc-utils.c b/drivers/clk/meson/meson-clkc-utils.c
> > new file mode 100644
> > index 000000000000..9a0620bcc161
> > --- /dev/null
> > +++ b/drivers/clk/meson/meson-clkc-utils.c
> > @@ -0,0 +1,25 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (c) 2023 Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > + */
> > +
> > +#include <linux/of_device.h>
> > +#include <linux/clk-provider.h>
> > +#include <linux/module.h>
> > +#include "meson-clkc-utils.h"
> > +
> > +struct clk_hw *meson_clk_hw_get(struct of_phandle_args *clkspec, void *clk_hw_data)
> > +{
> > +	const struct meson_clk_hw_data *data = clk_hw_data;
> > +	unsigned int idx = clkspec->args[0];
> > +
> > +	if (idx >= data->num) {
> > +		pr_err("%s: invalid index %u\n", __func__, idx);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> > +
> > +	return data->hws[idx];
> > +}
> > +EXPORT_SYMBOL_GPL(meson_clk_hw_get);
> > +
> > +MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/clk/meson/meson-clkc-utils.h b/drivers/clk/meson/meson-clkc-utils.h
> > new file mode 100644
> > index 000000000000..fe6f40728949
> > --- /dev/null
> > +++ b/drivers/clk/meson/meson-clkc-utils.h
> > @@ -0,0 +1,19 @@
> > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
> > +/*
> > + * Copyright (c) 2023 Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > + */
> > +
> > +#ifndef __MESON_CLKC_UTILS_H__
> > +#define __MESON_CLKC_UTILS_H__
> > +
> > +#include <linux/of_device.h>
> > +#include <linux/clk-provider.h>
> > +
> > +struct meson_clk_hw_data {
> > +	struct clk_hw	**hws;
> > +	unsigned int	num;
> > +};
> > +
> > +struct clk_hw *meson_clk_hw_get(struct of_phandle_args *clkspec, void *clk_hw_data);
> > +
> > +#endif