Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 於 2023年7月17日 週一 下午4:00寫道： > > On 17/07/2023 09:51, Dylan Hung wrote: > > Add reset definitions of AST2600 I3C and MAC controllers. > > > > Signed-off-by: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx> > > --- > > > > Resend v2 patch through my gmail account as the aspeedtech.com domain is blocked by gmail.com > > Where is the changelog? > Apologies for the oversight. I will ensure to include the changelog in V3. > > > > include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h > > index e149eee61588..712782177c90 100644 > > --- a/include/dt-bindings/clock/ast2600-clock.h > > +++ b/include/dt-bindings/clock/ast2600-clock.h > > @@ -90,7 +90,19 @@ > > /* Only list resets here that are not part of a clock gate + reset pair */ > > #define ASPEED_RESET_ADC 55 > > #define ASPEED_RESET_JTAG_MASTER2 54 > > + > > +#define ASPEED_RESET_MAC4 53 > > +#define ASPEED_RESET_MAC3 52 > > + > > +#define ASPEED_RESET_I3C5 45 > > +#define ASPEED_RESET_I3C4 44 > > +#define ASPEED_RESET_I3C3 43 > > +#define ASPEED_RESET_I3C2 42 > > +#define ASPEED_RESET_I3C1 41 > > +#define ASPEED_RESET_I3C0 40 > > +#define ASPEED_RESET_I3C 39 > > #define ASPEED_RESET_I3C_DMA 39 > > Why adding duplicate ID? Your commit msg or a comment here should > explain this. > There is no reset-line hardware available for `ASPEED_RESET_I3C_DMA`, so I have added a new macro to provide a better representation of the hardware design. However, since removing the old macro may affect all users, I decide to keep both the old and new macros. I will include the explainaion in the commit message of V3. > Best regards, > Krzysztof >
