On 17/07/2023 09:03, Marc Kleine-Budde wrote: > On 17.07.2023 08:41:07, Krzysztof Kozlowski wrote: >> On 16/07/2023 18:52, John Watts wrote: >>> Hello, >>> >>> On Sun, Jul 16, 2023 at 06:36:03PM +0200, Krzysztof Kozlowski wrote: >>>>> +static const struct sun4ican_quirks sun4ican_quirks_d1 = { >>>>> + .has_reset = true, >>>>> +}; >>>> >>>> Isn't this the same as previous? >>> >>> Yes, but I wanted to split up the new quirk in to its own patch. >> >> I don't understand why you need this new, duplicated entry. Aren't >> devices compatible? > > According to patch 4/4 the devices are not compatible. Ah, ok, I didn't go so far because it is not obvious to add support for a device in patch 3 which is already not correct and needs fix/followup in patch 4. Thanks. > Best regards, Krzysztof