On Mon, 2023-07-17 at 14:23 +0800, Hua Qian Li wrote: > On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote: > > On 17/07/2023 06:07, huaqian.li@xxxxxxxxxxx wrote: > > > From: Li Hua Qian <huaqian.li@xxxxxxxxxxx> > > > > > > The watchdog hardware of TI AM65X platform does not support > > > WDIOF_CARDRESET feature, add a reserved memory to save the > > > watchdog > > > reset cause, to know if the board reboot is due to a watchdog > > > reset. > > > > > > Signed-off-by: Li Hua Qian <huaqian.li@xxxxxxxxxxx> > > > --- > > > Changes in v4: > > > - Fix the coding style. > > > - Add usage note for the reserved memory. > > > - Link to v3: > > > > > > https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@xxxxxxxxxxx > > > > Much more changed. You added example in the bindings which no one > > asked > > for. Then you added multiple fake review tags to all the patches. > > > > Best regards, > > Krzysztof > > > Hi, > > Sorry for the wrong statement. I missed some key information and > missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who > has reviewed`. > > Best regards, > Li Hua Qian By the way, `Much more changes` came from the following message which was commented on [PATCH v3 0/3] Add support for WDIOF_CARDRESET on TI AM65x: One thing I keep wondering about: What prevents the Linux kernel from treating the special memory area like normal memory ? I would have expected some usage note, such as that the memory area must be reported as reserved to the kernel, but I don't see anything like that. Guenter
