On Wed, 12 Jul 2023 at 19:46, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 12/07/2023 15:02, Amit Pundir wrote: > > Add and document the reserved memory region property > > in the qcom,sdm845-mdss schema. > > > > Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx> > > Please keep consistent versioning, so this is new patch in v4. ACK. > > > --- > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > @@ -39,6 +39,11 @@ properties: > > interconnect-names: > > maxItems: 2 > > > > + memory-region: > > + maxItems: 1 > > + description: > > + Phandle to a node describing a reserved memory region. > > Your description says nothing new. It's entirely redundant/obvious. > Instead please describe what reserved memory is expected to be here. On it. I'll update in v5. Thanks. Regards, Amit Pundir > > > Best regards, > Krzysztof >