On 13/07/2023 12:34, Pranavi Somisetty wrote:
> Convert the Xilinx GMII to RGMII Converter device tree binding
> documentation to json schema.
> This converter is usually used as gem <---> gmii2rgmii <---> external phy
> and, it's phy-handle should point to the phandle of the external phy.
>
> Signed-off-by: Pranavi Somisetty <pranavi.somisetty@xxxxxxx>
...
> +
> +description:
> + The Gigabit Media Independent Interface (GMII) to Reduced Gigabit Media
> + Independent Interface (RGMII) core provides the RGMII between RGMII-compliant
> + ethernet physical media devices (PHY) and the Gigabit Ethernet controller.
> + This core can be used in all three modes of operation(10/100/1000 Mb/s).
> + The Management Data Input/Output (MDIO) interface is used to configure the
> + speed of operation. This core can switch dynamically between the three
> + different speed modes by configuring the converter register through mdio write.
> + The core cannot function without an external phy connected to it.
> +
> +properties:
> + compatible:
> + const: xlnx,gmii-to-rgmii-1.0
> +
> + reg:
> + minimum: 0
> + maximum: 31
> + description: The ID number for the phy, usually a small integer.
Drop the "usually small...", it's obvious from constraints.
> +
> + phy-handle: true
Where is this defined?
> +
> +required:
> + - compatible
> + - reg
> + - phy-handle
> +
> +unevaluatedProperties: false
Either you miss $ref or this should be additionalProperties. I bet it's
the first problem.
> +
> +examples:
> + - |
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + phy: ethernet-phy@0 {
> + reg = <0>;
> + };
Drop this node, quite obvious.
> + gmiitorgmii@8 {
> + compatible = "xlnx,gmii-to-rgmii-1.0";
> + reg = <8>;
> + phy-handle = <&phy>;
> + };
> + };
Best regards,
Krzysztof
