On Sat, 24 Jun 2023, Jean-Jacques Hiblot wrote: > This version of devm_of_led_get() doesn't fail if a LED is not found. > Instead it returns a NULL pointer. > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@xxxxxxxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > --- > drivers/leds/led-class.c | 25 +++++++++++++++++++++++++ > include/linux/leds.h | 2 ++ > 2 files changed, 27 insertions(+) What Markus said isn't wrong, but isn't a blocker either. He's just repeating Linus' preferences with respect to commit logs. Ideally you should be explaining what the problem is and what this patch does to solve it in a manner that is more directing and less explanatory in the past tense. -- Lee Jones [李琼斯]
