On Thu, Jul 13, 2023 at 03:18:23AM +0100, Daniel Golle wrote: > From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > Introduce MTK_NETSYS_V1 bit in the device capabilities for > MT7621/MT7622/MT7623/MT7628/MT7629 SoCs. > Use !MTK_NETSYS_V1 instead of MTK_NETSYS_V2 in the driver codebase. > This is a preliminary patch to introduce support for MT7988 SoC. Rather than using capability bits for versions, would it make more sense to use an integer for this, so you can do: if (eth->soc->netsys_version >= 2) { version 2 and later stuff } else { previous version stuff } ? I'm just thinking ahead to when we end up with stuff that v1 and v2 need but v3 and later don't. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!