On Thu, Jul 13, 2023 at 09:31:42AM +0530, Viresh Kumar wrote: > On 12-07-23, 16:02, Manivannan Sadhasivam wrote: > > +static int ufshcd_opp_set_rate(struct ufs_hba *hba, unsigned long freq) > > +{ > > + struct dev_pm_opp *opp; > > + > > + opp = dev_pm_opp_find_freq_floor_indexed(hba->dev, > > + &freq, 0); > > + if (IS_ERR(opp)) > > + return PTR_ERR(opp); > > + > > + dev_pm_opp_put(opp); > > You can't free the OPP while you are still using it :) > Ah... will fix it! - Mani > > + > > + return dev_pm_opp_set_opp(hba->dev, opp); > > +} > > -- > viresh -- மணிவண்ணன் சதாசிவம்