On 12/07/2023 16:35, Dmitry Baryshkov wrote: >>>> Rob asked you - "Is there more than 1 instance in a PMIC?" - and you did >>>> not answer positively, just mentioned something about drivers in >>>> downstream, which do not matter. So is the answer for that question: >>>> yes, you have two instances of the same PMIC differing by presence of >>>> PBS and other features"? >>>> >>> Sorry that was a misunderstanding on my part. >>> Yes, answer to Rob's question should have been "We have two instances of PMI632, >>> where one instance holds the pbs peripheral and the other holds the lpg >>> peripherals. The child node for pbs is needed so lpg client can access >>> the PMI632 regmap which contains the pbs peripheral." >> >> I guess I miss here something. What is "LPG client"? I don't understand >> why this LPG client needs existence of PBS node, to be able to get the >> regmap. >> >> PBS is a child of PMIC, so it can get regmap from the parent. What's >> more, which DT property passes the regmap from PMIC to LPG client? > > There are some PMICs which claim two SPMI SIDs. For such PMICs, each > SID is a separate device, so it is not directly possible to get the > regmap of the other SID. OK, maybe after implementing all the review changes - including dropping that singleton pattern - this will be clearer. Please send new version and we will discuss it from there. Thank you. Best regards, Krzysztof
