On 12.07.2023 00:39, Dmitry Baryshkov wrote: > On 12/07/2023 00:36, Konrad Dybcio wrote: >> On 9.07.2023 06:19, Dmitry Baryshkov wrote: >>> Add the nb7vpq904m, onboard USB-C redriver / retimer. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >>> --- >> [...] >> >>> + port@1 { >>> + reg = <1>; >>> + >>> + redriver_phy_con_ss: endpoint { >>> + remote-endpoint = <&usb_1_qmpphy_typec_mux_in>; >>> + data-lanes = <0 1 2 3>; >> That's USB+DP lines combined, or how does it work? I'm confused :/ > > 4 generic purpose SS lanes, which can be purposed for USB or for DP. Okay, so my gut did better than my brain. Other than that, I'm reading the bindings and it looks like ports 0 and 1 may possibly be swapped? Konrad > >> >> Konrad >>> + }; >>> + }; >>> + >>> + port@2 { >>> + reg = <2>; >>> + >>> + redriver_usb_con_sbu: endpoint { >>> + remote-endpoint = <&pm8150b_typec_sbu_out>; >>> + }; >>> + }; >>> + }; >>> + }; >>> }; >>> &mdss { >>> @@ -1294,7 +1334,7 @@ &usb_1_qmpphy { >>> }; >>> &usb_1_qmpphy_typec_mux_in { >>> - remote-endpoint = <&pm8150b_typec_mux_out>; >>> + remote-endpoint = <&redriver_phy_con_ss>; >>> }; >>> &usb_2 { >>> @@ -1382,7 +1422,15 @@ pm8150b_role_switch_out: endpoint { >>> port@1 { >>> reg = <1>; >>> pm8150b_typec_mux_out: endpoint { >>> - remote-endpoint = <&usb_1_qmpphy_typec_mux_in>; >>> + remote-endpoint = <&redriver_usb_con_ss>; >>> + }; >>> + }; >>> + >>> + port@2 { >>> + reg = <2>; >>> + >>> + pm8150b_typec_sbu_out: endpoint { >>> + remote-endpoint = <&redriver_usb_con_sbu>; >>> }; >>> }; >>> }; >